A federal tax credit and state rollouts of universal school choice are driving record demand for private-school scholarships, raising funding and accountability concerns.